Repository navigation
fix: Removed videoView on cell-reuse - #2750
Open
SystemKeeper wants to merge 2 commits into
Open
SystemKeeper wants to merge 2 commits into
SystemKeeper wants to merge 2 commits into
Conversation
SystemKeeper
changed the title
Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Marcel M眉ller <marcel-mueller@gmx.de>
Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Marcel M眉ller <marcel-mueller@gmx.de>
SystemKeeper
force-pushed
the
fix/noid/removed-video-view
branch
from
October 7, 2026 17:34
b27d893 to
e7fe090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on layouting and cell-reuse it is possible that we remove the wrong video view, essentially leaving the participant cell without a video. Therefore we need to ensure that the view is still the correct one.
Additionally this PR moves the cell code to swift, so best to check both commits individually.
馃 AI (if applicable)