Repository navigation
feat: RAR in the Compress format picker (through the user's WinRAR) - #269
Merged
Merged
Conversation
Choices can carry a disabled reason; the RAR format shows greyed out with the reason unless the service finds the user's WinRAR (IArchiveService.GetCreationAvailability). Test covers both cases with an injected locator. README/guides/changelog updated. Closes #258 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes #258 on top of the infrastructure in #267 and the pickers/size classes from #265/#268:
Choice<T>gained an optionalDisabledReason; disabled alternatives show greyed out in the picker with the reason.CompressFormatsgained RAR;AvailableCompressFormats()disables it with the service's reason unlessGetCreationAvailability(Rar)says WinRAR is installed. TheLineReserveheight reservation already reads the list, so the dialog size is unchanged.Rar_is_listed_disabled_with_the_reason_without_winrar_and_selectable_with_it(injected RAR locator, deterministic on any machine); the format picker test now expects four formats.ControlFS still never bundles, downloads or reimplements RAR (docs/decisions/0011).
Closes #258
🤖 Generated with Claude Code