Repository navigation
fix: show a recognizable icon for RAR archives - #275
Merged
Merged
Conversation
Use the icon Windows registered for .rar; when the Shell only has the generic blank page, draw an original archive icon (no third-party artwork). The icon cache drops when the .rar association changes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #274.
ShellIconProvider: for.rar, if the Shell returns the generic blank-page icon (same image index as an unregistered extension), renderArchiveGlyph(original box-with-zipper icon drawn in code, sized to the request, no third-party artwork). A registered association icon (e.g. WinRAR's) is used as before.IIconProvider.Revision: fingerprint of the.rarProgId/DefaultIcon (read at most every 2 s);IconLoaderdrops its cache when it changes, so installing/changing the program refreshes icons.IconRequestby extension). Other types untouched.🤖 Generated with Claude Code