Repository navigation
feat: add python-architecture-review skill with Cosmic Python guards - #5
Merged
Merged
Conversation
…dling Scope session-outside-uow to literal session receivers (session, self.session, db.session), include add, and name the actual receiver in evidence instead of flagging any .commit()/.query(). Handle top-level and relative domain, unit_of_work, and adapters paths via path parts. Cover bare patch, mocker.patch, multiline calls, and the .patch.object spelling while excluding dotted calls. Document the scanner advisory to report Minor mapping and fix the start-of-line docs grep. Add regression tests.
|
Sorry @azaharizaman, your pull request is larger than the review limit of 150,000 diff characters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the read-only python-architecture-review skill (Cosmic Python seams, complexity gate, target proposals, enforceable guards) with a stdlib-only scan_architecture.py scanner, three references, eval fixtures, and quality/structural contract coverage.
Includes review-driven scanner corrections: literal-session receivers with add, path-part handling for top-level/relative layouts, bare/mocker/multiline/.object mock coverage with dotted-call exclusion, advisory-to-Minor mapping docs, and regression tests.
Verification: full suite 580 passed, ruff clean, agentskills validate clean, git diff --check clean.