Conversation
nitin9977
force-pushed
the
nitin/geoip2-migration
branch
from
August 20, 2026 12:05
8e51466 to
c7acc07
Compare
jimf5
reviewed
Aug 25, 2026
jimf5
left a comment
jimf5
left a comment
Contributor
There was a problem hiding this comment.
It is worth adding IPv6 tests upon readiness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add testcases for ngx_http_geoip_module and ngx_stream_geoip_module to include tests for GeoIP2 backed by the maintained libmaxminddb.
Also added IPv6 testcases.
Tests PR: nginx/nginx#1655
Checklist
Before creating a PR, run through this checklist and mark each as complete:
README.mdand/orCHANGELOG.md).