Conversation
Check buffered and unbuffered empty responses, including HEAD, 204, and 304. Verify that control acknowledgements reach the upstream before the next request, and that GOAWAY and partial frames prevent reuse. See nginx/nginx#1726.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check keepalive reuse when an HTTP/2 upstream sends SETTINGS, PING, and an empty END_STREAM response together. This reproduces nginx/nginx#1726, reported by @bungle.
Accompanying source fix: nginx/nginx#1731.
The test covers empty 200, 204, 304, and HEAD responses in buffered and unbuffered modes. Each request pair starts on a fresh connection, and the backend checks that the SETTINGS and PING acknowledgements arrive before the second request. GOAWAY and an incomplete trailing frame are also checked to prevent unsafe reuse.
With nginx master at 231a60ee, 24 of 42 assertions fail. With the accompanying control-frame flush fix, all 42 pass, including ten consecutive runs. The HTTP/2 proxy tests, upstream_keepalive.t, and proxy_cache_convert_head.t pass together: 17 files, 292 assertions.
Tested with a native macOS arm64 debug build. Linux and sanitizer runs have not been performed.