Skip to content

Tests: proxy_header_timeout directive - #118

Open
vinaykumar-1591 wants to merge 1 commit into
nginx:masterfrom
vinaykumar-1591:proxy_header_timeout
Open

vinaykumar-1591 wants to merge 1 commit into
nginx:masterfrom
vinaykumar-1591:proxy_header_timeout

Conversation

@vinaykumar-1591

@vinaykumar-1591 vinaykumar-1591 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Tests to cover supporting prxy_header_timeout directive which aims to support timeouts.backendRequest defined from specification The gateway API specification.

companion source PR nginx/nginx#1738

Checklist

Before creating a PR, run through this checklist and mark each as complete:

@route443

Copy link
Copy Markdown
Member

Hi @vinaykumar-1591 ,

I've rewritten your commit. There are 5 main points:

  1. An nginx version check is needed. Specifically, this set of tests must be successfully skipped on versions older than 1.31.6. The simplest way to do this is via a separate .t. plus, this is established practice for the new directive.
  2. There is no check for the send phase, exactly what @arut explicitly requested in the PR.
  3. There is no check for proxy_next_upstream classification. This is what allowed the ssl issue to slip through.
  4. The proxy.t is already heavily loaded and takes a long time to exec. this allows for parallel run (prove -j).
  5. Added you as co-author

@route443 route443 changed the title Tests: test support covering proxy_header_timeout Tests: proxy_header_timeout directive Sep 17, 2026
Comment thread proxy_header_timeout.t Outdated
Co-authored-by: Vinay Kumar Tokala <v.tokala@f5.com>
@route443
route443 force-pushed the proxy_header_timeout branch from d3139d5 to 75657ab Compare September 18, 2026 00:37

@route443 route443 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sandbox CI passes without issues against the ba02005. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants