Tests: add HTTP robust retries test - #121
Open
sbhowmikf5 wants to merge 1 commit into
Open
sbhowmikf5 wants to merge 1 commit into
sbhowmikf5 wants to merge 1 commit into
Conversation
Co-authored-by: Sourav Bhowmik <s.bhowmik@f5.com>
route443
force-pushed
the
http-robust-retries
branch
from
September 18, 2026 21:58
7f542e2 to
a0226b2
Compare
route443
reviewed
Sep 18, 2026
route443
left a comment
Member
There was a problem hiding this comment.
Hi @sbhowmikf5 ,
I slightly changed the approach and re-write your tests, adding you as a co-author:
- Split the changes into two files, since a new proxy_next_upstream_delay direcive was introduced.
- I added gating based on the config, though this will affect the proxy_next_upstream.t as well. I think that's acceptable.
- Since we are dealing with delays, splitting the tests into separate files will have a positive impact on CI runtime.
- Added comments for the conf as well
- Reviewed code coverage and expanded the tests (72% -> 91% by gcov)
- Right now (against commits 466f7ba and 5bf8a71), the tests are failing, which is expected. The issues need to be addressed, and in theory, the tests should then pass :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test retries after all upstream peers are exhausted with the "no_live" parameter, including retry limits and delayed retries controlled by "proxy_next_upstream_delay".
Issue - nginx/nginx#1263
Feature PR - nginx/nginx#1757
Checklist
Before creating a PR, run through this checklist and mark each as complete: