Skip to content

Let a style pick its display and label fonts - #260

Merged
nmbrthirteen merged 1 commit into
mainfrom
feat/reference-fonts
Oct 2, 2026
Merged

nmbrthirteen merged 1 commit into
mainfrom
feat/reference-fonts

Conversation

@nmbrthirteen

Copy link
Copy Markdown
Owner

Adds fonts?: { display?: FontId; label?: FontId } to ThemeInput. FontId is one of grotesk (DM Sans), serif (Playfair Display italic), condensed (Barlow Condensed) or mono (Courier Prime), all already bundled. resolveTheme swaps the pack's display and label faces before applying motion and overrides, so colours, surface and motion are untouched.

This lets a look matched from a reference carry its typeface. For example, WSJ and Vox frames both use bold condensed type, which the matcher could not express before.

3 new tests. 227 pass.

A style can name a display and a label font from the four bundled families (grotesk, serif, condensed, mono) on top of any pack, so a look matched from a reference can carry its typeface. The pack's colours, surface and motion stay as they were.
@coderabbitai

coderabbitai Bot commented Oct 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c0ebeafd-d0a7-43ac-94d4-3b7ffcfe9c05
📥 Commits

Reviewing files that changed from the base of the PR and between 33da36c and 73dcd63.

📒 Files selected for processing (2)
  • remotion/src/style/theme.test.ts
  • remotion/src/style/theme.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nmbrthirteen
nmbrthirteen merged commit 280810d into main Oct 2, 2026
14 checks passed
@nmbrthirteen nmbrthirteen mentioned this pull request Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant