Skip to content

fix(git-node): fix SSH passphrase input when promoting a release#1097

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:ssh-input-broken
Jul 14, 2026
Merged

fix(git-node): fix SSH passphrase input when promoting a release#1097
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:ssh-input-broken

Conversation

@aduh95

@aduh95 aduh95 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.22%. Comparing base (d9fff73) to head (988ede5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1097   +/-   ##
=======================================
  Coverage   65.22%   65.22%           
=======================================
  Files          45       45           
  Lines        6916     6916           
=======================================
  Hits         4511     4511           
  Misses       2405     2405           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 requested a review from Renegade334 July 13, 2026 16:50

@Renegade334 Renegade334 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this isn't the only place where ssh could potentially go interactive?

@aduh95

aduh95 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

I'm guessing this isn't the only place where ssh could potentially go interactive?

It's the only place I've had problems with it recently

@aduh95 aduh95 merged commit 10c6f35 into nodejs:main Jul 14, 2026
11 checks passed
@aduh95 aduh95 deleted the ssh-input-broken branch July 14, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants