feat(v8)!: synchronize Rust crates with major updates#1117
Draft
Renegade334 wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
+ Coverage 62.37% 63.06% +0.68%
==========================================
Files 48 50 +2
Lines 7892 8288 +396
==========================================
+ Hits 4923 5227 +304
- Misses 2969 3061 +92 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This is a breaking change, as Cargo is now a mandatory requirement for running a major update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An implementation of nodejs/node#64191 (comment). Depends on #1116 and nodejs/node#64482.
Broadly speaking, the process is as follows:
third_party/rustrepository alongside the other DEPS. Note that this never enters the Node.js git tree, as it's deliberately not exempt from .gitignore, but fetching it here can make use of the existing DEPS machinery.cargo treeto walk the temporal_capi dependency tree inthird_party/rust/chromium_crates_io, and populate a list of transitive dependencies, so that we only vendor what we need for Temporal.third_party/rust/chromium_crates_iotodeps/crates.cargo vendorhere, because Chromium uses its own gnrt toolchain to vendor its crate dependencies, which also applies any floating patches inthird_party/rust/chromium_crates_io/patches. Usingcargo vendorwould fetch fresh copies from crates.io, and miss these patches.cargo vendor, gnrt always adds some variation of the version string when naming the vendored crate directories. It doesn't matter for the rust build, since cargo doesn't care about the directory names, but it does mean that we need to update the temporal_capi include path in crates.gyp whenver we update the crates.Example result: nodejs/node@f3bf260
Like Chromium, this approach doesn't add a
rust-versionto the crates manifest; Cargo will read this from the dependencies' manifests anyway.