vfs: read RealFSProvider files from open fd#64104
Merged
nodejs-github-bot merged 2 commits intoJun 27, 2026
Merged
Conversation
Read RealFileHandle contents through the open file descriptor instead of reopening the original real path. This keeps already-open VFS file descriptors usable after the backing file is renamed. Use positioned reads so readFileSync() and readFile() preserve the handle's current offset. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
nodejs-github-bot
added
needs-ci
mcollina
reviewed
Jun 25, 2026
mcollina
added
request-ci
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
added
the
author ready
Collaborator
jasnell
approved these changes
Jun 27, 2026
trivikr
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 8cb8312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64103
RealFileHandle.readFileSync()andreadFile()previously reopened theoriginal real path. If the backing file was renamed after the VFS fd was opened,
fs.readFileSync(fd, ...)failed withENOENT.This changes
RealFileHandleto read through the already-open real fd usingpositioned reads. That matches native filesystem behavior for renamed open files
and preserves the handle's current offset.
The async
readFile()path continues to use asyncstat()andread()operations.
Assisted-by: openai:gpt-5.5