quic: fix crash when no onstream handler is set with unistream#64158
Open
efekrskl wants to merge 3 commits into
Open
quic: fix crash when no onstream handler is set with unistream#64158efekrskl wants to merge 3 commits into
efekrskl wants to merge 3 commits into
Conversation
Signed-off-by: Efe Karasakal <hi@efe.dev>
Signed-off-by: Efe Karasakal <hi@efe.dev>
Signed-off-by: Efe Karasakal <hi@efe.dev>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as a fix for #64030 (unidirectional stream crashing when there's no
onstreamhandler). Which was caused by JS synchronously destroying the stream (because there was no handler) and native code still trying to access it.While testing that, I also ran into teardown issues around
destroy()in the same repro. I ended up including this one too, because without it I couldn't test cleanly.Session::Impl::~Impl()could drop the last owner of theSession, then keep usingsession_->env()afterward. I changed the order so anything that still needs env() runs before the session can disappear.