quic: changes for nghttp3_conn_close_stream2 - #64574
Conversation
|
Review requested:
|
|
@pimtery @jasnell Not to be merged now. It is to be prepared when newer nghttp3 arrives in node.js |
|
Expect building to fail until the update. |
nghttp2 will introduce a version 2 callback and function for closing streams. This prepares node.js for the change. Other changes may be required for its full potential. Signed-off-by: Marten Richter <marten.richter@freenet.de>
Co-authored-by: James M Snell <jasnell@gmail.com>
04d9c88 to
1a8bf05
Compare
|
The newer nghttp3 had been merged. Separate from this also ngtcp3 needs an update to address the changes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64574 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.01%
==========================================
Files 759 759
Lines 248290 248342 +52
Branches 46859 46876 +17
==========================================
+ Hits 224241 224273 +32
- Misses 15472 15505 +33
+ Partials 8577 8564 -13 🚀 New features to boost your workflow:
|
|
I have also added the ngtcp2 change. |
nghttp2 will introduce a version 2 callback
and function for closing streams.
This prepares node.js for the change.
Other changes may be required for
its full potential.