Conversation
nodejs-github-bot
added
cluster
Fixes: nodejs#64869 Signed-off-by: islandryu <shimaryuhei@gmail.com>
islandryu
force-pushed
the
worktree-cluster-eaddrinuse-64869
branch
from
August 7, 2026 14:29
bd5c12f to
ed8f6a3
Compare
islandryu
marked this pull request as ready for review
August 7, 2026 15:22
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65020 +/- ##
==========================================
+ Coverage 90.04% 90.14% +0.10%
==========================================
Files 713 751 +38
Lines 224950 252648 +27698
Branches 42530 47542 +5012
==========================================
+ Hits 202548 227754 +25206
- Misses 14188 16182 +1994
- Partials 8214 8712 +498
🚀 New features to boost your workflow:
|
PickBas
reviewed
Aug 10, 2026
Contributor
There was a problem hiding this comment.
I have a suggestion for the test: it passes on an unpatched build under SCHED_RR (the POSIX default), so it wouldn't catch a regression on Linux/macOS. The PR fixes behavior with SCHED_NONE, so could the tests cover both SCHED_RR and SCHED_NONE policies regardless of the OS?
Member
Author
There was a problem hiding this comment.
Good catch! I've covered both policies.
StefanStojanovic
approved these changes
Aug 25, 2026
StefanStojanovic
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
StefanStojanovic
added
the
request-ci
github-actions
Bot
added
request-ci-failed
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/76474/ ✔ Build data downloaded ℹ Existing CI run found: https://ci.nodejs.org/job/node-test-pull-request/76474/ ✖ Refusing to start a potentially duplicate CI job. Use the "Resume build" button in the Jenkins UI, or start a new CI manually.https://github.com/nodejs/node/actions/runs/34959502102 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64869
Prevent an assertion error in
child.jswhen a worker attempts to listen twice on the same port by detecting duplicate handle registrations in the primary process.