tty: add stub for async OSC 11 background color query - #65111
Draft
nirupam-06 wants to merge 3 commits into
Draft
Conversation
Signed-off-by: nirupamzenith <sainirupamkakani@gmail.com>
nodejs-github-bot
added
needs-ci
avivkeller
reviewed
Aug 8, 2026
Co-authored-by: Aviv Keller <me@aviv.sh>
Author
|
Thanks for the catch on the extra blank line, @avivkeller — applied. Still early/draft while I work out the OSC 11 query/response logic (timeout handling + guarding against the response leaking into stdin, per the known Windows Terminal/Warp issue), but wanted the API shape visible early. Will ping again once it's ready for a full review. |
Signed-off-by: nirupamzenith <sainirupamkakani@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #65058
This is an early draft laying out the proposed API shape for
writeStream.getBackgroundColor()— an opt-in, best-effort, asyncAPI for querying the terminal's background color via OSC 11.
Currently a stub (always resolves
undefined) with doc and testscaffolding in place. Real OSC 11 query/response/timeout logic to
follow — opening early per the project's contributing guidelines
so design discussion can happen against real code.