Skip to content

meta: make code-and-learn PRs fast-trackable - #65122

Closed
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:code-and-learn-fast-tracking
Closed

meta: make code-and-learn PRs fast-trackable#65122
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:code-and-learn-fast-tracking

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Ref: https://github.com/nodejs/node-core-utils/blob/main/lib/pr_checker.js#L276

nodejs/TSC#1878 made me realize that @node-core/utils considers the code-and-learn label to be a fast-trackable label, but our CI auto-gates those PRs and prevents them from being sent to the commit queue. With RenderATL coming up, the CI should be updated to match NCU and allow these PRs through.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 7, 2026
@aduh95

aduh95 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Let's go the other way around: if you found surprising that code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. is a fast-trackable label and our tooling also assumes it's not the case, chances are more folks feel the same, so a "better" way forward is to simplify the rule to only apply to fast-track PRs that do not need to wait for 48 hours to land.

@avivkeller avivkeller closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants