Skip to content

test: account for [EnforceRange] in test-webcrypto-prototype-pollution - #65173

Closed
panva wants to merge 1 commit into
nodejs:mainfrom
panva:fix-test-webcrypto
Closed

test: account for [EnforceRange] in test-webcrypto-prototype-pollution#65173
panva wants to merge 1 commit into
nodejs:mainfrom
panva:fix-test-webcrypto

Conversation

@panva

@panva panva commented Aug 9, 2026

Copy link
Copy Markdown
Member

Fixes CI.

#65115 didn't account for a spec change that landed in #65091

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 9, 2026
@panva panva added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2026
@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 9, 2026
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 9, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

panva added a commit that referenced this pull request Aug 9, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65173
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@panva

panva commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

Landed in 8c8190f

@panva panva closed this Aug 9, 2026
@panva
panva deleted the fix-test-webcrypto branch August 9, 2026 20:45
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (8f51878) to head (49c1a8c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65173      +/-   ##
==========================================
+ Coverage   90.31%   90.32%   +0.01%     
==========================================
  Files         759      759              
  Lines      248456   248456              
  Branches    46874    46877       +3     
==========================================
+ Hits       224389   224423      +34     
+ Misses      15501    15462      -39     
- Partials     8566     8571       +5     

see 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants