build: enable Perfetto by default

[aduh95]

Refs: nodejs/diagnostics#654

[nodejs-github-bot]

Review requested:

• @nodejs/actions

[StefanStojanovic]

@aduh95, I'll look into Windows failures.

[StefanStojanovic]

This is what got it to compile for me locally. In short, it was a configuration problem(s), so gyp changes resolved it all.

Details

From f31ec1fc602e9711756d9ca1d7ae386221e14662 Mon Sep 17 00:00:00 2001
From: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Date: Wed, 9 Sep 2026 08:24:06 +0200
Subject: [PATCH] build,win: fix Perfetto

Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com>
---
 deps/perfetto/perfetto.gyp | 8 ++++++++
 node.gypi                  | 5 +++++
 tools/v8_gypfiles/v8.gyp   | 6 +++++-
 3 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/deps/perfetto/perfetto.gyp b/deps/perfetto/perfetto.gyp
index 083d0b386dd..697256401a3 100644
--- a/deps/perfetto/perfetto.gyp
+++ b/deps/perfetto/perfetto.gyp
@@ -18,6 +18,14 @@
       'sources': [
         '<@(perfetto_sdk_sources)',
       ],
+      'conditions': [
+        ['OS=="win"', {
+          'defines': [
+            'WIN32_LEAN_AND_MEAN',
+            'NOMINMAX',
+          ],
+        }],
+      ],
     },
   ]
 }
diff --git a/node.gypi b/node.gypi
index 104e884e661..1ca77fa3fee 100644
--- a/node.gypi
+++ b/node.gypi
@@ -93,6 +93,11 @@
     [ 'OS=="linux" and target_arch=="s390x"', {
       'cflags': [ '-march=z14' ],
     }],
+    [ 'v8_use_perfetto==1', {
+      'dependencies': [
+        'deps/perfetto/perfetto.gyp:perfetto_sdk',
+      ],
+    }],
     [ 'node_enable_d8=="true"', {
       'dependencies': [ 'tools/v8_gypfiles/d8.gyp:d8' ],
     }],
diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
index a976148ddab..2b1ee51c8f1 100644
--- a/tools/v8_gypfiles/v8.gyp
+++ b/tools/v8_gypfiles/v8.gyp
@@ -1758,7 +1758,11 @@
         }],
         ['v8_use_perfetto==1', {
           'sources!': [
-            '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"  "\\"v8_libplatform.*?v8_use_perfetto.*?sources \\-= ")',
+            '<(V8_ROOT)/src/libplatform/tracing/trace-buffer.cc',
+            '<(V8_ROOT)/src/libplatform/tracing/trace-buffer.h',
+            '<(V8_ROOT)/src/libplatform/tracing/trace-writer.cc',
+            '<(V8_ROOT)/src/libplatform/tracing/trace-writer.h',
+            '<(V8_ROOT)/src/tracing/trace-event-no-perfetto.h',
           ],
           'sources': [
             '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"  "\\"v8_libplatform.*?v8_use_perfetto.*?sources \\+= ")',
-- 
2.45.2.windows.1

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/77258/

[aduh95]

@nodejs/platform-aix Build failure: ../deps/perfetto/sdk/perfetto.h:1035:5: error: function-like macro 'PERFETTO_BUILDFLAG_DEFINE_PERFETTO_OS_APPLE' is not defined

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/77272/

[richardlau]

@nodejs/platform-aix Build failure: ../deps/perfetto/sdk/perfetto.h:1035:5: error: function-like macro 'PERFETTO_BUILDFLAG_DEFINE_PERFETTO_OS_APPLE' is not defined

I think the actual error is this:
e.g. https://ci.nodejs.org/job/node-test-commit-aix/65261/nodes=aix72-power9/console

01:02:46 In file included from ../deps/perfetto/sdk/perfetto.cc:21:
01:02:46 ../deps/perfetto/sdk/perfetto.h:295:2: error: OS not supported (see build_config.h)
01:02:46   295 | #error OS not supported (see build_config.h)
01:02:46       |  ^

Same failure is seen on SmartOS.

[jasnell]

doh!

[aduh95]

How should we proceed? Force --without-perfetto for those platforms or wait until support is added upstream? @nodejs/platform-aix @nodejs/platform-smartos

[jasnell]

good question. I think as long as the observable behavior with trace events is still the same either way, forcing --without-perfetto on those platforms is likely ok. We'd need to avoid a case where tracing output is broken on just those. If we still consider this experimental, then it should be fine omitting the unsupported platforms, however.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/77320/

[aduh95]

Adding to the TSC agenda to make sure 53d853b has consensus (the alternative would be to block Perfetto enabling until support for all platforms is added upstream)

[legendecas]

good question. I think as long as the observable behavior with trace events is still the same either way, forcing --without-perfetto on those platforms is likely ok. We'd need to avoid a case where tracing output is broken on just those. If we still consider this experimental, then it should be fine omitting the unsupported platforms, however.

I think the output format is a significant observable behavior (if it counts) between Chrome legacy trace format and the new Perfetto protobuf format. Though, we don't expect the exported trace to be "compatible" across systems, like, there is no interoperation on the exported trace between systems. They can be visualized by chrome://tracing or https://ui.perfetto.dev/ individually. So on behavior-wise, yes, this is an observable change.

But it shouldn't be a compat problem that some platforms do not enable perfetto by default.

[legendecas]

Before turning Perfetto ON by default, I'll take updating https://github.com/search?q=repo%3Anodejs%2Fnode+skipIfPerfettoEnabled&type=code these tests as a blocker.

[mcollina]

lgtm