benchmark: add --csv option to compare.js with --analyze - #65922
Open
jasnell wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
jasnell
force-pushed
the
jasnell/bench-compare-csv
branch
from
September 9, 2026 01:27
520b0e2 to
df6708b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65922 +/- ##
==========================================
- Coverage 89.99% 89.99% -0.01%
==========================================
Files 785 785
Lines 269282 269282
Branches 51296 51285 -11
==========================================
- Hits 242348 242335 -13
- Misses 17445 17447 +2
- Partials 9489 9500 +11 🚀 New features to boost your workflow:
|
aduh95
reviewed
Sep 10, 2026
aduh95
reviewed
Sep 10, 2026
jasnell
force-pushed
the
jasnell/bench-compare-csv
branch
from
September 10, 2026 15:45
df6708b to
2c335f8
Compare
Member
Author
|
ok, had to tweak it a bit more to account for the progress display... but passing |
aduh95
reviewed
Sep 10, 2026
jasnell
force-pushed
the
jasnell/bench-compare-csv
branch
from
September 10, 2026 16:00
2c335f8 to
53b9e22
Compare
aduh95
reviewed
Sep 10, 2026
jasnell
force-pushed
the
jasnell/bench-compare-csv
branch
from
September 10, 2026 20:53
c6e0e3a to
0ad655a
Compare
Contributor
|
Can you address the linter failures? |
jasnell
force-pushed
the
jasnell/bench-compare-csv
branch
from
September 10, 2026 21:52
0ad655a to
363ebf9
Compare
aduh95
reviewed
Sep 10, 2026
jasnell
force-pushed
the
jasnell/bench-compare-csv
branch
from
September 10, 2026 22:28
68c4812 to
77be9bd
Compare
aduh95
approved these changes
Sep 10, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
ronag
approved these changes
Sep 11, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
request-ci
github-actions
Bot
added
request-ci-failed
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/77359/ SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/34725026707 |
Add a `--csv {filename}` option to benchmark/compare.js
to capture the CSV when the `--analyze` option is used
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
jasnell
force-pushed
the
jasnell/bench-compare-csv
branch
from
September 13, 2026 00:05
77be9bd to
c9c6a65
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
--csv {filename}option to benchmark/compare.js to capture the CSV when the--analyzeoption is used