Skip to content

deps,v8,tools: cherry-pick 95efbaf92a0d and disable fortify warnings in CI - #66020

Open
aduh95 wants to merge 3 commits into
nodejs:mainfrom
aduh95:fewer-warnings
Open

aduh95 wants to merge 3 commits into
nodejs:mainfrom
aduh95:fewer-warnings

Conversation

@aduh95

@aduh95 aduh95 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

This aims to remove the following warnings from CI logs:

In file included from ../../src/util.h:29,
                 from ../../src/inspector/node_string.h:10,
                 from gen/src/node/inspector/protocol/Forward.h:19,
                 from gen/src/node/inspector/protocol/Protocol.h:18:
/nix/store/bh12ybnp9rcrw2rkrnhzm6ahdpqzxgwm-v8-14.6.202.34-node.33/include/v8-profiler.h: In constructor 'v8::HeapProfiler::HeapSnapshotOptions::HeapSnapshotOptions()':
/nix/store/bh12ybnp9rcrw2rkrnhzm6ahdpqzxgwm-v8-14.6.202.34-node.33/include/v8-profiler.h:1128:27: warning: 'v8::HeapProfiler::HeapSnapshotOptions::global_object_name_resolver' is deprecated: Use context_name_resolver callback instead. [-Wdeprecated-declarations]
 1128 |     HeapSnapshotOptions() {}
      |                           ^
/nix/store/bh12ybnp9rcrw2rkrnhzm6ahdpqzxgwm-v8-14.6.202.34-node.33/include/v8-profiler.h:1142:25: note: declared here
 1142 |     ObjectNameResolver* global_object_name_resolver = nullptr;
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/nix/store/bh12ybnp9rcrw2rkrnhzm6ahdpqzxgwm-v8-14.6.202.34-node.33/include/v8-profiler.h:1128:27: warning: 'v8::HeapProfiler::HeapSnapshotOptions::global_object_name_resolver' is deprecated: Use context_name_resolver callback instead. [-Wdeprecated-declarations]
 1128 |     HeapSnapshotOptions() {}
      |                           ^
/nix/store/bh12ybnp9rcrw2rkrnhzm6ahdpqzxgwm-v8-14.6.202.34-node.33/include/v8-profiler.h:1142:25: note: declared here
 1142 |     ObjectNameResolver* global_object_name_resolver = nullptr;
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../src/memory_tracker.h:6,
                 from ../../src/aliased_buffer.h:7:
/nix/store/bh12ybnp9rcrw2rkrnhzm6ahdpqzxgwm-v8-14.6.202.34-node.33/include/v8-profiler.h: In constructor 'v8::HeapProfiler::HeapSnapshotOptions::HeapSnapshotOptions()':
/nix/store/bh12ybnp9rcrw2rkrnhzm6ahdpqzxgwm-v8-14.6.202.34-node.33/include/v8-profiler.h:1128:27: warning: 'v8::HeapProfiler::HeapSnapshotOptions::global_object_name_resolver' is deprecated: Use context_name_resolver callback instead. [-Wdeprecated-declarations]
 1128 |     HeapSnapshotOptions() {}
      |                           ^
/nix/store/bh12ybnp9rcrw2rkrnhzm6ahdpqzxgwm-v8-14.6.202.34-node.33/include/v8-profiler.h:1142:25: note: declared here
 1142 |     ObjectNameResolver* global_object_name_resolver = nullptr;
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/nix/store/bh12ybnp9rcrw2rkrnhzm6ahdpqzxgwm-v8-14.6.202.34-node.33/include/v8-profiler.h:1128:27: warning: 'v8::HeapProfiler::HeapSnapshotOptions::global_object_name_resolver' is deprecated: Use context_name_resolver callback instead. [-Wdeprecated-declarations]
 1128 |     HeapSnapshotOptions() {}
      |                           ^
/nix/store/bh12ybnp9rcrw2rkrnhzm6ahdpqzxgwm-v8-14.6.202.34-node.33/include/v8-profiler.h:1142:25: note: declared here
 1142 |     ObjectNameResolver* global_object_name_resolver = nullptr;
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/node_file_utils.cc: In function 'int node::WriteFileSync(const char*, uv_buf_t*, size_t)':
../../src/node_file_utils.cc:62:32: warning: enumerated and non-enumerated type in conditional expression [-Wextra]
   62 |       int err = req.result < 0 ? req.result : UV_EIO;
      |                 ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~

isheludko and others added 2 commits September 14, 2026 11:45
Original commit message:

    [api] Delete usages of v8::HeapProfile::ObjectNameResolver

    ... and start deprecation of the class definition.

    Bug: 333672197
    Change-Id: I9517d09cd1e01b9893384cb9408d714affcefdee
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7614327
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#105492}

Refs: v8/v8@95efbaf
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 14, 2026
@Renegade334

Copy link
Copy Markdown
Member

Presumably this is for the build spam?

`req.result` is `ssize_t` while `UV_EIO` is an enumerator, which GCC
flags as mixing enumerated and non-enumerated types in a conditional
expression.

Assisted-by: Devin
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 14, 2026
@aduh95

aduh95 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Presumably this is for the build spam?

This is to reduce the noise in CI logs. v8/v8@95efbaf applies cleanly, and the other changes are completely harmless AFAICT

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.19%. Comparing base (e5778f7) to head (0470c7f).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file_utils.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66020      +/-   ##
==========================================
- Coverage   90.22%   90.19%   -0.03%     
==========================================
  Files         785      785              
  Lines      269357   269368      +11     
  Branches    51511    51508       -3     
==========================================
- Hits       243016   242966      -50     
- Misses      16853    16913      +60     
- Partials     9488     9489       +1     
Files with missing lines Coverage Δ
src/node_file_utils.cc 62.58% <0.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@saitanallensantiago26-beep

This comment was marked as duplicate.

@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Sep 15, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants