Skip to content

[Release] v8.11.0 - #5821

Closed
github-actions[bot] wants to merge 1 commit into
mainfrom
release/v8.11.0
Closed

github-actions[bot] wants to merge 1 commit into
mainfrom
release/v8.11.0

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

What's Changed

New Contributors

Full Changelog: v8.10.2...v8.11.0

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vwong

vwong commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@mcollina It looks like the breakage came from my PR #5677 interacting with #5799, to which the fix should be:

index ea319559..52065958 100644
--- a/test/pool.js
+++ b/test/pool.js
@@ -1397,7 +1397,7 @@ test('pool does not dispatch to clientTtl-evicted client when stale drain fires'
     clientTtl: 1,
     factory: () => new FakeClient()
   })
-  after(() => pool.destroy())
+  after(() => pool.destroy().catch(() => {}))

   const handler = { onResponseError (_controller, err) { throw err } }

How can I help get this across the line?

@vwong

vwong commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Actually, here's the PR that'll do it for you #5828

@mcollina mcollina closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants