Repository navigation
connect: cleanup and start reworking APIs - #1494
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
yukibtc
force-pushed
the
nostr-connect-cleanup
branch
4 times, most recently
from
October 15, 2026 11:39
bb2b983 to
d24d2b8
Compare
2 of 3 tasks
Focus `nostr-connect` on client functionality, consistent with the other signer crates. Remove the remote signer implementation, leaving service lifecycle, authorization and key management to NIP-46 providers while reducing public API surface and maintenance burden. Start reworking the APIs by introducing a client builder for client configuration and construction. Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
yukibtc
force-pushed
the
nostr-connect-cleanup
branch
from
October 19, 2026 08:11
d24d2b8 to
2009676
Compare
agent-p1p
added a commit
to erskingardner/rust-nostr
that referenced
this pull request
Oct 19, 2026
Catch up with the `AtomicUsize::fetch_update` deprecation fix (nostrdevkit#1496), which unbreaks the "Check stable" CI job, and the nostr-connect API rework (nostrdevkit#1494). The merge has no conflicts, and the fork's delta against upstream is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Focus
nostr-connecton client functionality, consistent with the other signer crates. Remove the remote signer implementation, leaving service lifecycle, authorization and key management to NIP-46 providers while reducing public API surface and maintenance burden.Start reworking the APIs by introducing a client builder for client configuration and construction.
Checklist
CHANGELOG.md(if applicable)