Repository navigation
Closed
Conversation
The picture is a Pause button too, so the HUD-wide locator matched two elements and failed in strict mode.
Fix the embed play-mode e2e spec's ambiguous Pause locator
… of downloading them again /__url-load-proxy answered no-store and dropped the upstream's validators, so every embed ?track= (and player ?music=) load from another origin downloaded the whole archive. Move the proxy into url-load-proxy.ts, answer no-cache, and pass ETag / Last-Modified and If-None-Match / If-Modified-Since through, so an unchanged archive comes back as a 304.
Cache proxied embed tracks until the archive changes
Owner
Author
|
Closing: this release will go out together with the embed AUTO checkbox. |
Contributor
Exports Benchmark🔴 2 regressions · 2 improvements · 12 within noise · 879 compared
Regressions (2)
Improvements (2)
Within noise (12): past the threshold, but the runs overlap
I/O-bound, not judged (19)These cases touch the filesystem, so their time follows the OS cache and the disk more than the code.
Excluded: too fast to time (83)A timed sample lasted 1 µs or less on at least one side (usually a base commit from before calls were batched), so its time is timer noise and no change is shown.
…and 71 more. Run details
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@be-music/worker-play0.1.3:/__url-load-proxyanswersno-cacheand passesETag/Last-ModifiedandIf-None-Match/If-Modified-Sincethrough, so an unchanged embed?track=or player?music=archive from another origin comes back as a 304 instead of downloading again (Cache proxied embed tracks until the archive changes #873).🤖 Generated with Claude Code