Repository navigation
Merged
Conversation
The picture is a Pause button too, so the HUD-wide locator matched two elements and failed in strict mode.
Fix the embed play-mode e2e spec's ambiguous Pause locator
… of downloading them again /__url-load-proxy answered no-store and dropped the upstream's validators, so every embed ?track= (and player ?music=) load from another origin downloaded the whole archive. Move the proxy into url-load-proxy.ts, answer no-cache, and pass ETag / Last-Modified and If-None-Match / If-Modified-Since through, so an unchanged archive comes back as a 304.
Cache proxied embed tracks until the archive changes
…?mode= be-music-preview-select and be-music-preview-start gain an autoPlay property that shows an AUTO checkbox (the list's header, under the play button) and emits auto-play-change. The embed starts it from ?mode= and switches its mode on a change; under the play button it loads the play again in the other mode.
…r it On a phone held upright the lanes stopped well above the controls, and on a phone held sideways (SP or DP) the judgement line sat under the seek bar. Keep clear only the controls' 54 CSS px as tall as they get on a 320 px phone and a 16 px gap (previewJudgementInset), in both orientations. The preview HUD puts the controls along the bottom of the screen rather than the stage, so a DP chart letterboxed on a phone held upright keeps them off its lanes.
… on a phone A phone or tablet (or a browser asking to save data) no longer downloads the track as soon as the embed opens. It shows a Load button (be-music-preview-start's new load mode and caption) with the file name and the size a HEAD request reports; /__url-load-proxy now answers HEAD with the upstream's Content-Length.
Embed: AUTO checkbox, lanes down to the seek bar, and Load before downloading on a phone
Contributor
Exports Benchmark🔴 3 regressions · 1 improvement · 15 within noise · 882 compared
Regressions (3)
Improvements (1)
Changed packages
All 113 cases
New exports (1)
Within noise (15): past the threshold, but the runs overlap
…and 3 more. I/O-bound, not judged (19)These cases touch the filesystem, so their time follows the OS cache and the disk more than the code.
Excluded: too fast to time (80)A timed sample lasted 1 µs or less on at least one side (usually a base commit from before calls were batched), so its time is timer noise and no change is shown.
…and 68 more. Run details
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@be-music/app-play0.9.0: an AUTO checkbox switches the embed between the AUTO preview and the viewer's play without?mode=; the lanes reach down to just above the seek bar without running under it (SP and DP, either orientation); a phone or tablet waits for a Load button showing the archive's size before downloading (Embed: AUTO checkbox, lanes down to the seek bar, and Load before downloading on a phone #875).@be-music/player-ui0.5.0:autoPlay/auto-play-changeon the preview list and start screens,loadmode andcaptiononbe-music-preview-start,previewJudgementInsetandPREVIEW_CONTROLS_CSS_HEIGHT, and the HUD's controls along the bottom of the screen (Embed: AUTO checkbox, lanes down to the seek bar, and Load before downloading on a phone #875).@be-music/worker-play0.1.3 / 0.1.4:/__url-load-proxylets the browser revalidate a proxied archive (no-cache,ETag/Last-Modified, conditional requests) so an unchanged one is not downloaded again (Cache proxied embed tracks until the archive changes #873), and answers HEAD with the archive'sContent-Length(Embed: AUTO checkbox, lanes down to the seek bar, and Load before downloading on a phone #875).@be-music/player-browser0.13.2,@be-music/player-ui-react/player-ui-vue0.2.3.🤖 Generated with Claude Code