Prevent dry runs from starting validation - #9
Open
lforchini-ntnx wants to merge 3 commits into
Open
lforchini-ntnx wants to merge 3 commits into
lforchini-ntnx wants to merge 3 commits into
Conversation
Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com>
Collaborator
The engine may decide to revert but actual reverting will be skipped because dry run is true, isn't this currently the case? |
Collaborator
Author
In main, nothing tracks it right now. I haven't had a look at the other PRs yet, but maybe there's something added there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think dry-runs should start a validation process which may then revert and modify the actual thread count. Alternative solution is keep track if the validation was started by a dry-run and prevent it on potential revert.