feat(agentic): add vary header to markdown negotiation - #1431
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by an Is Agentic scan of docus.dev, which saw
Vary: none.Summary
Advertise
Vary: Accept, User-Agenton pages that answer in both HTML and markdown. Without it a shared cache can serve the HTML variant to an agent asking for markdown, or the reverse, since both live at the same URL.Changes
layer/modules/vercel-markdown-rewrite.ts(renamed frommarkdown-rewrite.ts)The rewrite headers carry
vary, plus one trailingcontinue: trueroute applying it to the HTML variant of every negotiated path. It runs after the rewrites, which terminate for markdown clients, so only non-markdown requests reach it.Paths are regex-escaped when building that route: a slug like
/en/concepts/node-20.xwould otherwise leak a wildcard into the Vercel matcher.The new name makes the scope explicit, since the module is a no-op on any non-Vercel preset: matching on a request header has no equivalent in the static config of other providers, so the header is emitted here rather than through provider-agnostic route rules.