fix(dev): show loading screen in initial startup - #1421
Conversation
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/nuxt-cli/test/e2e/dev.spec.ts`:
- Around line 43-52: Update the polling loop in the e2e setup around initPromise
so it stops when initialization rejects or a bounded startup deadline expires.
Race or otherwise observe initPromise while retrying fetch, preserve successful
listener detection, and throw the initialization error or a timeout error so the
cleanup path still executes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 33f38973-9b29-4376-813e-a7cab5018aed
📒 Files selected for processing (2)
packages/nuxt-cli/src/dev/utils.tspackages/nuxt-cli/test/e2e/dev.spec.ts
🔗 Linked issue
📚 Description
since #1105 and nuxt/cli v3.30, we haven't shown the loading screen on initial
nuxt devstartup, only on reload. this was an unintentional regression of dropping the proxy (which showed the loading screen) 🙈