fix(sync): report an archived repository once, not on every run - #1590
fix(sync): report an archived repository once, not on every run#1590Polkilof wants to merge 2 commits into
Conversation
`sync()` writes what it finds into the module file, and the CLI then exits 1 if anything was found. For an archived repository those two steps contradict each other: the run computes `archived: true`, exits non-zero, and the `autofix-ci` step never gets to commit the flag — so the next run rediscovers the same repository and fails again. Since `windicss/nuxt-windicss-module` was archived, `pnpm sync` has failed on every pull request opened against this repository, while `ci` stayed green. An archived repository is now reported only the first time it is seen, that is when the flag is not yet recorded in the module file. A freshly submitted module that is already archived still fails, because nothing has recorded it yet, and `pnpm cli sync <name>` keeps reporting it every time it is run by hand. This also commits the two values sync has been unable to write: - windicss: `archived: true` - content: `compatibility.nuxt`, which `@nuxt/content@3.15.2` declares as `^3.19.0 || >=4.1.0` while the registry still promised `>=3.0.0-rc.3`
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe synchronization result now records whether a module became archived during the current sync. Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change is localized to archived-repository reporting and related module metadata updates; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (9 skipped: 9 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
A correction to my own commit message: the bot reverted the Which means the compatibility regression reported for What is left in this PR stands on its own. |
sync()writes what it finds into the module file, and the CLI then exits 1 if anything was found. For an archived repository those two steps contradict each other: the run computesarchived: true, exits non-zero, and theautofix-cistep never gets to commit the flag — so the next run rediscovers the same repository and fails again. Sincewindicss/nuxt-windicss-modulewas archived,pnpm synchas failed on every pull request opened against this repository, whilecistayed green.An archived repository is now reported only the first time it is seen, that is when the flag is not yet recorded in the module file. A freshly submitted module that is already archived still fails, because nothing has recorded it yet, and
pnpm cli sync <name>keeps reporting it every time it is run by hand.This also commits the two values sync has been unable to write:
archived: truecompatibility.nuxt, which@nuxt/content@3.15.2declares as^3.19.0 || >=4.1.0while the registry still promised>=3.0.0-rc.3🔗 Linked issue
📚 Description