fix(decorations): only offer default devices the project can run on - #537
Merged
Merged
Conversation
- Skip devices whose platform directory (ios/, macos/, web/, ...) is missing from the project - Detect desktop and web targets by platform prefix instead of a fixed list - Ignore notices printed before the `flutter devices --machine` JSON - Skip the default device lookup outside a Flutter project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #536.
ios/,macos/,web/, ...) exists in the project, likeflutter rundoeslinux-riscv64are coveredflutter devices --machineJSON no longer break parsing