fix(lsp): stop enabling onlyAnalyzeProjectsWithOpenFiles by default - #541
Merged
Merged
Conversation
dartls now analyses the project at root_dir instead of rebuilding analysis roots on every file open/close. A root that resolves to the home directory or filesystem root is dropped so a lone file does not trigger analysis of everything beneath it. The option can be re-enabled via lsp.init_options. Fixes #540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onlyAnalyzeProjectsWithOpenFiles = true; dartls analyses the project atroot_dirrather than rebuilding analysis roots on every open/close.root_dirthat resolves to$HOMEor the filesystem root (e.g. a lone file under a dotfiles repo); without a root the server falls back to analysing the open files' packages.lsp.init_options.Fixes #540