feat(dap): show debug adapter progress natively and keep it alive - #553
Merged
Merged
Conversation
- Launch, attach, hot reload and hot restart progress from the Flutter debug adapter is shown as native progress (Neovim 0.12+) - Shared ui.progress helper resends running progress every 10s, since Ghostty drops an OSC 9;4 bar after 15s without updates; it stops after 2 min without a real update, and progress still running when the session closes is marked failed - Devices and widget preview use the same helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui.progresshelper, also used by devices and widget preview, resends running progress every 10s because Ghostty drops the bar after 15s without updates. The keep-alive stops after 2 min without a real update, and progress still running when the DAP session closes (including an adapter crash) is marked failed, so the bar can't stay up indefinitely.