feat(run): stop the flutter process when exiting nvim - #554
Merged
Merged
Conversation
Send SIGTERM to the CLI runner's `flutter run` job on VimLeavePre so the tool stops the app (or detaches, when attached) instead of lingering. The DAP runner is already handled by nvim-dap's ExitPre hook. Closes #401
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VimLeavePre, send SIGTERM to the CLI runner'sflutter runjob and wait up to 3s for it to exit. The flutter tool ignores stdin closing, so before this it and the app kept running after nvim quit.runsession stops the app, anattachsession only detaches.ExitPrehook already terminates its sessions.Closes #401