Skip to content

Update android robot package name, target API/Gradle, and localisations - #534

Merged
thias15 merged 11 commits into
ob-f:masterfrom
3dwesupport:android-robot-v2
Aug 26, 2026
Merged

Update android robot package name, target API/Gradle, and localisations#534
thias15 merged 11 commits into
ob-f:masterfrom
3dwesupport:android-robot-v2

Conversation

@hardikgarg02

@hardikgarg02 hardikgarg02 commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator
  1. Updated Android robot app's package from org.openbot to org.openbot.app.robot.
  2. Updated the robot module's target and compile SDK to API 36 and upgraded the Android Gradle Plugin to 8.9 ( required for Google Play Store listing )
  3. Added missing translations for the Web Controller settings section and Web Signaling Server field (web_controller_category, web_signaling_server).

@thias15

thias15 commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

One thing to confirm before merging: google-services.json's oauth_client entries were edited to package_name: "org.openbot.app.robot" while keeping the same certificate_hash values. That's necessary but not sufficient — Google Sign-In needs an actual Android OAuth client registered in Firebase/Google Cloud Console for (org.openbot.app.robot, that SHA-1), and editing the JSON locally doesn't create that registration. Has this been confirmed against the real console (and ideally tested with a live Google Sign-In on a build using the new applicationId)?

@thias15

thias15 commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Given #535 scrubbed the real Firebase credentials for iOS, could you do the same here? google-services.json still has the real client_id/certificate_hash/mobilesdk_app_id, and googleServices/README.md already has the matching "set up your Firebase project" walkthrough to add a dummy-data note to.

One thing first though: please confirm the org.openbot.app.robot OAuth client registration (from the comment above) actually works with a real Sign-In test before swapping to dummy values, since once it's dummied out there's nothing left to compare against the console.

@thias15 thias15 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's addressed, thanks. Good to merge from my side.

@thias15
thias15 merged commit 0679c46 into ob-f:master Aug 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants