Skip to content

Add missing Yubico intermediate certs - #42

Merged
timweri merged 5 commits into
mainfrom
add-missing-yubico-intermediates
Sep 22, 2026
Merged

timweri merged 5 commits into
mainfrom
add-missing-yubico-intermediates

Conversation

@timweri

@timweri timweri commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Adding missing old intermediate certs:

  • YUBICO_FIDO_ROOT_CA_450203556

Adding missing new intermediate certs:

  • YUBICO_FIDO_ATTESTATION_B2_1
  • YUBICO_PIV_ATTESTATION_B2_1

@timweri
timweri requested a balanced review from Copilot September 22, 2026 18:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new security-sensitive trust paths lack end-to-end attestation fixtures.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2 Low severity

Open (2)
What changed in this PR

Adds missing Yubico PIV/FIDO trust chains and refactors certificate-chain verification.

Changes:

  • Adds B2 attestation certificates and a new FIDO root.
  • Centralizes known chains and validates embedded certificates.
  • Updates dependencies, crate version, and dependency-freshness CI.
File Description
src/​yubikey/​verification.rs Adds the PIV B2 chain and chain validation test.
src/​fido/​verification.rs Adds FIDO B2/new-root trust paths and tests.
Cargo.toml Bumps crate and der-parser versions.
Cargo.lock Updates resolved dependencies.
.github/​workflows/​dependency-freshness.yml Adds dependency-age checking.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/fido/verification.rs
Comment thread src/yubikey/verification.rs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The newly trusted certificate paths lack end-to-end attestation fixtures that verify the intended compatibility behavior.

Review effort: Balanced
Findings: 2 Low severity

Open (2)

@timweri
timweri requested a balanced review from Copilot September 22, 2026 20:20
@timweri
timweri marked this pull request as ready for review September 22, 2026 20:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Expanding trusted certificate material and adding a third-party CI action warrants final human provenance and security validation.

Review effort: Balanced
Findings: None

Resolved since last review (2)

@timweri
timweri merged commit 8af9f15 into main Sep 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants