Add missing Yubico intermediate certs - #42
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new security-sensitive trust paths lack end-to-end attestation fixtures.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds missing Yubico PIV/FIDO trust chains and refactors certificate-chain verification.
Changes:
- Adds B2 attestation certificates and a new FIDO root.
- Centralizes known chains and validates embedded certificates.
- Updates dependencies, crate version, and dependency-freshness CI.
| File | Description |
|---|---|
src/yubikey/verification.rs |
Adds the PIV B2 chain and chain validation test. |
src/fido/verification.rs |
Adds FIDO B2/new-root trust paths and tests. |
Cargo.toml |
Bumps crate and der-parser versions. |
Cargo.lock |
Updates resolved dependencies. |
.github/workflows/dependency-freshness.yml |
Adds dependency-age checking. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
obelisk
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adding missing old intermediate certs:
Adding missing new intermediate certs: