fix(oxcaml): odoc generation for parameter implementations - #16200
Merged
Conversation
Signed-off-by: Arthur Wendling <arthur@tarides.com>
Signed-off-by: Arthur Wendling <arthur@tarides.com>
Signed-off-by: Arthur Wendling <arthur@tarides.com>
art-w
force-pushed
the
parameterised-doc
branch
from
August 25, 2026 09:25
a6170fe to
7f1df4a
Compare
Signed-off-by: Arthur Wendling <arthur@tarides.com>
Alizter
approved these changes
Aug 25, 2026
Alizter
added
odoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The odoc generation was skipping all libraries with an
implementsfield (= assuming virtual modules), which meant that the documentation of OxCaml parameterized libraries was missing important pages (see ocaml/odoc#1464)