Skip to content

timeline broken? #4

Description

@3merillon

Hi,

It seems the timeline click function doesn't work, it always resets to 0:00, I will tell you if I find the reason.

Sorry, after testing it seems this problem only happens in the latest Firefox browser, not in Safari IE or Chrome which I tested later.

And finally, I fixed it, firefox doesn't support offsetX... although I'm not sure if it will work if someone has a leftbar browser addon or search bar..

replace this line in the javascript:
$player.seekPerc( e.offsetX * 100 / $('#timeline').width() );
with:
$player.seekPerc( (e.clientX - $(this).offset().left) * 100 / $(this).width() );

the $(this)s are just for speed... you can use $('#timeline').

Anyways, this problem brought me to another minor issue. You cannot click the timeline if you haven't started playing the track yet or if the track has finished and is reset to 0:00 (also with the official player), I think there is no real reason for this behavior especially as there is a hand mouse pointer in the official player one would think a click would have some effect..

cheers,
Zen

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions