Skip to content

Restore Mac App Store marketing, support, and privacy pages - #107

Merged
gitar-bot[bot] merged 2 commits into
mainfrom
fix/restore-app-store-pages
Sep 30, 2026
Merged

gitar-bot[bot] merged 2 commits into
mainfrom
fix/restore-app-store-pages

Conversation

@offyotto

Copy link
Copy Markdown
Owner

Change

The App Store marketing, support, and privacy URLs return 404 after #103 deleted docs/Mac-App-Store/.

Restore these three pages from 0d6020a, the commit immediately before #103:

  • docs/Mac-App-Store/index.html
  • docs/Mac-App-Store/support/index.html
  • docs/Mac-App-Store/privacy/index.html

Preserve the page content and canonical URLs. Remove only the obsolete font preloads because #104 deleted that font.

GitHub Pages serves main:/docs at xnu.is-a.dev. After merge and deployment, the existing GitHub URLs will redirect to the restored pages.

The change leaves the README, homepage, and App Store Connect fields unchanged.

Verification

  • Confirmed that all three existing GitHub URLs redirect to xnu.is-a.dev and return HTTP 404.

  • Served docs/ with a temporary local HTTP server. All three restored page routes returned HTTP 200 with the expected HTML.

  • Passed 52 local link and asset checks, including fragment targets, styles, scripts, icons, and screenshots.

  • Compared each restored file with its historical source. Each file matches, except for the obsolete font preload.

  • Confirmed that the patch contains exactly three HTML files.

  • git diff --cached --check passed.

  • Checks cover the changed behavior.

  • The restored pages document the App Store edition.

  • Security review: not applicable to this static HTML restoration.

Comment thread docs/Mac-App-Store/index.html
gitar-bot[bot]

This comment was marked as resolved.

Co-authored-by: offyotto <245704867+offyotto@users.noreply.github.com>
@gitar-bot
gitar-bot Bot dismissed their stale review September 30, 2026 11:26

✅ All code review findings resolved.

Configure merge blocking

@gitar-bot
gitar-bot Bot enabled auto-merge (squash) September 30, 2026 11:26

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@gitar-bot gitar-bot Bot added the gitar-approved Added by Gitar label Sep 30, 2026
@gitar-bot

gitar-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 closed / 1 findings

🟡 Medium risk · Restoring three public App Store pages changes which website routes resolve.

Restores three Mac App Store pages (index.html, support/index.html, privacy/index.html) from before their deletion in #103, removing obsolete font preloads and fixing CSS class references to match the current styles.css. All verification checks passed including local link validation and historical file comparison. No open issues.

Auto-approved: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria.

✅ 1 closed
✅ Bug: Restored pages use CSS classes the current styles.css no longer has

📄 docs/Mac-App-Store/index.html:29 📄 docs/Mac-App-Store/index.html:97 📄 docs/Mac-App-Store/index.html:102 📄 docs/Mac-App-Store/index.html:106 📄 docs/Mac-App-Store/index.html:112 📄 docs/Mac-App-Store/index.html:131 📄 docs/Mac-App-Store/index.html:142 📄 docs/Mac-App-Store/index.html:157 📄 docs/Mac-App-Store/support/index.html:29 📄 docs/Mac-App-Store/support/index.html:45 📄 docs/Mac-App-Store/support/index.html:50 📄 docs/Mac-App-Store/support/index.html:53 📄 docs/Mac-App-Store/support/index.html:61 📄 docs/Mac-App-Store/support/index.html:62 📄 docs/Mac-App-Store/support/index.html:72 📄 docs/Mac-App-Store/support/index.html:84 📄 docs/Mac-App-Store/privacy/index.html:29 📄 docs/Mac-App-Store/privacy/index.html:49 📄 docs/Mac-App-Store/privacy/index.html:52 📄 docs/Mac-App-Store/privacy/index.html:57 📄 docs/Mac-App-Store/privacy/index.html:58 📄 docs/Mac-App-Store/privacy/index.html:71 📄 docs/Mac-App-Store/privacy/index.html:85 📄 docs/Mac-App-Store/privacy/index.html:107
The pages were copied from 0d6020a, but #105 (9d35749) then rewrote docs/styles.css (315+/361−). That rewrite removed .act-heat, .page-lede, .meta-line, .duo, .tally, .tally.is-out and .trio. Every primary CTA (act act-heat), the page header, the two-column included/excluded lists and the three-column article grids on all three pages now have no styling. The pages will return 200, but the App Store support and privacy URLs will show a broken layout, and the CTAs will look like plain links. The pages also still point to styles.css?v=20, while the site now serves ?v=21. The check that passed was for asset existence, not for class coverage. Fix this by switching the markup to the current classes (for example act-primary in place of act-heat), or by adding the missing rules back to styles.css. Also bump the stylesheet version to v=21.

Review coverage

🤖 Auto-approval Approved

📋 Rules No rules evaluated

🧪 Functional validation Not enabled · Set up

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e78c2f62c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/Mac-App-Store/index.html
Comment thread docs/Mac-App-Store/index.html
@gitar-bot
gitar-bot Bot merged commit b3c7835 into main Sep 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitar-approved Added by Gitar

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants