Skip to content

Require interactive review for supported AUR flows - #9791

Closed
tonibergholm-codento wants to merge 1 commit into
omacom:quattrofrom
tonibergholm-codento:aur-review-gate
Closed

Require interactive review for supported AUR flows#9791
tonibergholm-codento wants to merge 1 commit into
omacom:quattrofrom
tonibergholm-codento:aur-review-gate

Conversation

@tonibergholm-codento

Copy link
Copy Markdown

Summary

  • hold AUR changes during unattended and non-terminal updates, preserving the caller's original terminal state across the update logger's pseudo-terminal
  • require complete PKGBUILD views, available build-file diffs, and the final package-manager confirmation for supported interactive AUR installs and updates
  • route the AUR picker and dependent installers through the reviewed path, remove the sudo keepalive, and propagate failures
  • keep AUR-dependent migrations pending when their required review cannot be completed
  • document the emergency review gate, its limitations, and the next trust boundaries

This is a compatibility-phase review gate. It does not sandbox PKGBUILDs, bind recipes and sources to immutable hashes, inspect built artifacts independently, or produce signed attestations.

Testing

  • bash test/shell.d/update-aur-pkgs-test.sh
  • bash test/shell.d/pkg-aur-review-test.sh
  • existing update sequence, lock, disk-space, migration, and Quattro upgrade shell tests
  • ./test/cli
  • bash -n for changed shell scripts and tests
  • git diff --check

The broader shell suite also exercised the new tests successfully. Its remaining failures were unrelated existing/environment cases: three require a sibling omarchy-pkgs checkout, plus launch-about-test and network-qr-test.

@tonibergholm

Copy link
Copy Markdown

Superseded by #9795, which contains the reviewed fixes and uses tonibergholm/omarchy as the source fork.

1 similar comment
@tonibergholm-codento

Copy link
Copy Markdown
Author

Superseded by #9795, which contains the reviewed fixes and uses tonibergholm/omarchy as the source fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants