Skip to content

Add staticcheck version in calling workflow - #198

Merged
gab-arrobo merged 1 commit into
omec-project:mainfrom
gab-arrobo:dep-upgrade
Oct 12, 2026
Merged

gab-arrobo merged 1 commit into
omec-project:mainfrom
gab-arrobo:dep-upgrade

Conversation

@gab-arrobo

Copy link
Copy Markdown
Contributor

No description provided.

@gab-arrobo
gab-arrobo requested review from a team and a balanced review from Copilot October 12, 2026 16:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The pinned reusable workflow does not define the new input, causing workflow validation to fail.

1 open finding
What changed in this PR

Adds an explicit Staticcheck version to the shared static-analysis workflow invocation.

Changes:

  • Passes staticcheck_version: 'v0.8.1'.
File Description
.github/​workflows/​main.yml Configures the requested Staticcheck version.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/main.yml
Copilot AI balanced review requested due to automatic review settings October 12, 2026 17:54
@gab-arrobo
gab-arrobo force-pushed the dep-upgrade branch 2 times, most recently from 9d9cb80 to 0a08d1d Compare October 12, 2026 17:54
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The version exists and matches the reusable workflow’s supported input.

1 open finding

🧠 Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 12, 2026 17:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The configured input and version are valid for the pinned reusable workflow.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

@andybavier andybavier left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gab-arrobo
gab-arrobo merged commit 010013d into omec-project:main Oct 12, 2026
9 checks passed
@gab-arrobo
gab-arrobo deleted the dep-upgrade branch October 12, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants