Repository navigation
Make retry/polling intervals overridable vars to speed up tests - #200
Merged
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
🟡 Changes recommended
The eviction test can finish before background eviction runs, leaving that behavior untested.
1 open finding
What changed in this PR
This PR speeds up NRF cache tests by replacing fixed waits with condition polling and adopting model accessors.
Changes:
- Add a polling helper for TTL and eviction tests.
- Use model constructors, setters, and getters in test code.
| File | Description |
|---|---|
| nrfcache/nrfcache_test.go | Replace fixed sleeps with polling and update model initialization and access. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
cmaciocco
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also use accessors (New/Set/Get)