Remember Lobby disconnect - #1438
Open
BazookaJoe26 wants to merge 2 commits into
Open
Conversation
LegendaryBlueShirt
added
the
network/multiplayer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had frequent disconnect issues, playing with my brother with both of us having a very good Ethernet connection ping 10ms.
I played with him after the changes and it was a lot more stable, there were still some disconnects, but at least those were not silent, and after those changes it was also possible to connect again after a disconnect without closing the software, which was the case before.
The second commit is about failing audio in a multiplayer match, in many cases the Audi effects were gone after the first match. Rollback combat sounds were faded in over 500 ms. Many hit sounds are shorter and therefore practically inaudible. The fade-in is now 10 ms; in addition, running sound handles are preserved during rollback.
All changes on the first commit:
The aggressive 1-second timeout for NAT connection attempts is reset to the ENet standard (5–30 seconds) after a successful connection. This was likely the main cause of the frequent disconnections.
A lobby failure no longer terminates the direct connection to opponents.
Dead lobby connections are detected upon return and reestablished.
When an opponent disconnects, the message “Opponent disconnected” now appears.
The issue with incorrect access to arena data during player selection has been fixed.
Two potential “double-free” issues upon disconnect have been resolved.
Relay connections are now correctly treated as simultaneous opponent and lobby failures.
Winx64
Commits assisted with ChatGPT5.6 Sol