Repository navigation
Conversation
Compose private fresh mapped entries through the existing immutable constructor and owned lifetime runner. Name the actual entry kind at public guards and check both controlled-session owners before preparation effects. Preserve ordinary behavior and public mapped inhibition. Refuse unsupported replacement lifecycle composition before retiring or mutating the old owner. Tests cover both map profiles, finite/master semantics, stale ownership, repeated replacement refusals and ordinary/public guard parity. No production F/G provider or public activation is introduced.
Code Review ✅ Approved🟡 Medium risk · Mapped-entry guards and dual-owner checks change runtime admission, so commands could be refused when either controlled-session owner has mapped state. Composes private fresh mapped entries through the existing immutable constructor and owned lifetime runner, naming the actual entry kind at public guards and checking both controlled-session owners before preparation effects. No issues found. VerificationRules No rules evaluated Functional validation Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
|
PR-cycle state — maintained automatically. Do not edit by hand. Mechanical PR-cycle state (JSON){
"approval": {
"candidate_revision_fingerprint": "sha256:5b15ca9ab4ea5f9672eb5a507a14b881cfbf06b5d9bfc94f4e57e75ba653c8cb",
"evidence": {
"attestations": [],
"candidate_revision_fingerprint": "sha256:5b15ca9ab4ea5f9672eb5a507a14b881cfbf06b5d9bfc94f4e57e75ba653c8cb",
"check_conclusions": [
{
"conclusion": "SUCCESS",
"name": "Bash native evidence checks",
"run_id": 124580362961,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124580362961,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 124571686868
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 124573471267
},
{
"conclusion": "SUCCESS",
"name": "Linux CI checks",
"run_id": 124575925980,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575925980,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-amd64)",
"run_id": 124575927357,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575927357,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 124575927218,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575927218,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 124575926740,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575926740,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 124575927494,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575927494,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-amd64)",
"run_id": 124575950725,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575950725,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 124575926231,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575926231,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
}
],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"operation_identity": "sha256:362685de6d0007c8840f71e1385865925b59cb53f9cc8d30f1a4c2c543e79c53",
"review_request": {
"body_digest": "sha256:5d54896e239be0da76f0a18581e911cea7bfd84107dd551ce88ad9205d5e1fc0",
"id": 6545244174
},
"review_result": {
"body_digest": "sha256:dafecd50aa1a2d1929804fe6f6eb9d4bd3904235bc107ff8e2a397aeff3e5d07",
"id": 6545254844
}
},
"evidence_fingerprint": "sha256:42d25146b24bc9ee706a2a7697c36d7a355cf5708565e1c1414c61a83fba7d00",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"operation_identity": "sha256:362685de6d0007c8840f71e1385865925b59cb53f9cc8d30f1a4c2c543e79c53",
"review_request_id": 6545244174,
"review_result_id": 6545254844,
"status": "approved-evidence-recorded"
},
"candidate_revision_fingerprint": "sha256:5b15ca9ab4ea5f9672eb5a507a14b881cfbf06b5d9bfc94f4e57e75ba653c8cb",
"check_conclusions": [
{
"conclusion": "SUCCESS",
"name": "Bash native evidence checks",
"run_id": 124580362961,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124580362961,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 124571686868
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 124573471267
},
{
"conclusion": "SUCCESS",
"name": "Linux CI checks",
"run_id": 124575925980,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575925980,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-amd64)",
"run_id": 124575927357,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575927357,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 124575927218,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575927218,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 124575926740,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575926740,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 124575927494,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575927494,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-amd64)",
"run_id": 124575950725,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575950725,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 124575926231,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575926231,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
}
],
"check_observations": [
{
"checks": [
{
"conclusion": "SUCCESS",
"name": "Bash native evidence checks",
"run_id": 124580362961,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41212994812/job/124580362961",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124580362961,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 124571686868,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/runs/124571686868"
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 124573471267,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/runs/124573471267"
},
{
"conclusion": "SUCCESS",
"name": "Linux CI checks",
"run_id": 124575925980,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41212994812/job/124575925980",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575925980,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-amd64)",
"run_id": 124575927357,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41212994812/job/124575927357",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575927357,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 124575927218,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41212994812/job/124575927218",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575927218,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 124575926740,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41212994812/job/124575926740",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575926740,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 124575927494,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41212994812/job/124575927494",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575927494,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-amd64)",
"run_id": 124575950725,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41212994812/job/124575950725",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575950725,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 124575926231,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41212994812/job/124575926231",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 111713392957,
"event": "pull_request",
"job_id": 124575926231,
"name_unique": true,
"run": {
"conclusion": "success",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"number": 3484,
"status": "completed"
},
"run_id": 41212994812,
"workflow_id": 302865520
}
}
],
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"id": "sha256:2fe68374ae686d3e5f8711214c24ed46f7998fa70820503a807d6da9b9e6389a",
"required_checks": [
"Bash native evidence checks",
"Gitar",
"Linux CI checks",
"Target smoke (darwin-amd64)",
"Target smoke (darwin-arm64)",
"Target smoke (linux-amd64)",
"Target smoke (linux-arm64)",
"Windows host smoke (windows-amd64)",
"Windows host smoke (windows-arm64)"
],
"status": "success"
}
],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"delivery_deferrals": [],
"findings": [],
"pr": {
"base_ref": "pr315",
"base_sha": "844f3ac9e863916cbaa5a7e0a490fbfdb7dfdd7a",
"body_digest": "sha256:ba2d1287efd28966a5b8abf92474ee59043cd78d278f2b6723c90d429a9673e6",
"body_identity_version": 2,
"diff_digest": "sha256:bc3f9bd6ccbb18525345b7df7aeea02902531f1f5a4a1562244b2d2675d771fb",
"head_ref": "pr316",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"pr": 316,
"repository": "omry/reploy",
"scope_authority": [
{
"digest": "sha256:078e63e84d432c2aad03120ca30e40ec4572a8970e6bf6be9d5008608a30f435",
"path": "docs/MULTI_IDENTITY_D_DESIGN.md"
},
{
"digest": "sha256:f5058bb465d6af9d58b98eb6fde19edd4ed710aff1cc2588173757d37cdbbc58",
"path": "docs/MULTI_IDENTITY_E_DESIGN.md"
},
{
"digest": "sha256:3ef44a7a0be43648f5df1faad39b16101978662c58c87d6fa8e7409093a58fe9",
"path": "docs/MULTI_IDENTITY_IMPLEMENTATION_PLAN.md"
},
{
"digest": "sha256:fe188bb8a80f7f235e99b023283749a3a9e3172e4adf70b70b495d80e50e9218",
"path": "docs/MULTI_IDENTITY_MAIL_RECONCILIATION.md"
},
{
"digest": "sha256:b049714f4a85d0f3fb204615897374377690564627bfcdd03e50c945fb042826",
"path": "docs/MULTI_IDENTITY_SECURITY_CONTRACT.md"
}
],
"title_digest": "sha256:38268c5f1a3b34bf50a4b8bb69eff490354e6e00b6ac2133e0db04ddc34b1edb"
},
"record_version": 4,
"review_observations": [],
"review_requests": [
{
"base_established_at": "2026-10-31T15:03:24Z",
"base_ref": "pr315",
"base_sha": "844f3ac9e863916cbaa5a7e0a490fbfdb7dfdd7a",
"body_digest": "sha256:5d54896e239be0da76f0a18581e911cea7bfd84107dd551ce88ad9205d5e1fc0",
"created_at": "2026-10-31T15:15:02Z",
"head_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"id": 6545244174,
"kind": "regular-review"
}
],
"review_results": [
{
"base_ref": "pr315",
"base_sha": "844f3ac9e863916cbaa5a7e0a490fbfdb7dfdd7a",
"body_digest": "sha256:dafecd50aa1a2d1929804fe6f6eb9d4bd3904235bc107ff8e2a397aeff3e5d07",
"commit_id": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"id": 6545254844,
"inline_message_ids": [],
"request_comment_id": 6545244174,
"result_kind": "clean",
"status": "result",
"submitted_at": "2026-10-31T15:15:58Z",
"unresolved_thread_ids": []
}
],
"revision_fingerprint": "sha256:5b15ca9ab4ea5f9672eb5a507a14b881cfbf06b5d9bfc94f4e57e75ba653c8cb",
"rounds": [
{
"applied_fix_paths": [],
"disposition_changes": [],
"effective_diff_digest": "sha256:bc3f9bd6ccbb18525345b7df7aeea02902531f1f5a4a1562244b2d2675d771fb",
"finding_ids": [],
"invariants": [
"Fresh supported entries use shared immutable constructor and owned runner.",
"Unsupported replacement refuses before retirement and preserves old ownership.",
"Both session owners, ordinary behavior and public mapped guards remain checked."
],
"outcome": "clean",
"proposed_fix_paths": [],
"resulting_head": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"review_observation_id": null,
"review_request_id": 6545244174,
"review_result_id": 6545254844,
"reviewed_head": "b6627eff4b4775cd1485c45770373d15d1c665b7",
"root_cause": "No PR source finding or correction. Original local/CI timeout observations retained; bounded unchanged-head retries passed complete local validation and every required CI job. Independent full and remote reviews clean. No root-cause source fix claimed.",
"round": 1,
"unresolved_current_slice_findings": 0,
"unresolved_design_blockers": 0
}
],
"schema": "awd:swe:pr-cycle-state",
"version": 2
} |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Compose private fresh mapped entries through the existing immutable constructor and owned lifetime runner. Name the actual entry kind at public guards and check both controlled-session owners before preparation effects.
Preserve ordinary behavior and public mapped inhibition. Refuse unsupported replacement lifecycle composition before retiring or mutating the old owner. Tests cover both map profiles, finite/master semantics, stale ownership, repeated replacement refusals and ordinary/public guard parity. No production F/G provider or public activation is introduced.