Repository navigation
Fix CI dependency resolution for pinned Transformers and VibeVoice - #789
Merged
Merged
Conversation
Using --no-deps for Transformers 5.16 left the VibeVoice Hub 2 dependency incompatible. Resolve the pinned Transformers requirements together with the editable project before installing only VibeVoice with --no-deps, preserving both revisions. Add five AutoConfig smokes and six offline contract tests; the tests pass. A local fresh-environment resolver run was not performed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a2a5b82-7cd3-4a76-bb94-0998527ea723 Signed-off-by: titaiwang <titaiwang@microsoft.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Fresh-environment CI validation is still needed to confirm dependency resolution and the AutoConfig smoke check succeed.
No open issues 🎉
What changed in this PR
This PR corrects CI dependency installation by resolving pinned Transformers alongside editable Mobius before installing VibeVoice with --no-deps. Both source revisions remain unchanged.
Changes:
- Update all five VibeVoice installation steps across four workflows.
- Separate Transformers and VibeVoice requirements and add an
AutoConfigimport smoke check. - Add regression tests for installation order, workflow structure, and source-pin format.
| File | Description |
|---|---|
tests/ci_dependencies_test.py |
Tests install ordering, smoke checks, and source requirement structure. |
requirements/ci/vibevoice.txt |
Retains only VibeVoice and documents its dependency exception. |
requirements/ci/transformers.txt |
Separates the existing Transformers source pin for dependency resolution. |
.github/workflows/nightly_l2.yml |
Updates nightly dependency installation and adds the smoke check. |
.github/workflows/main.yml |
Updates both VibeVoice installation steps and adds smoke checks. |
.github/workflows/gpu_l5_generation_e2e.yml |
Updates generation-test dependency installation and adds the smoke check. |
.github/workflows/gpu_l4_golden_parity.yml |
Updates golden-parity dependency installation and adds the smoke check. |
Review effort: Balanced
Performance Comparison
|
justinchuby
approved these changes
Oct 25, 2026
Real dependency installation and AutoConfig import smokes remain. The removed YAML-string checks overconstrain workflow structure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9a2a5b82-7cd3-4a76-bb94-0998527ea723 Signed-off-by: titaiwang <titaiwang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix VibeVoice CI dependency installation by resolving the pinned Transformers source together with the editable Mobius project, then installing the pinned VibeVoice source with
--no-deps.Failure and fix
The failing install sequence first resolved Transformers 5.20.2 with Hub 2.3.0 and
httpx2, then force-installed Transformers 5.16.0.dev0 from the combined VibeVoice requirements using--no-deps. That left Hub 2.3.0 installed despite the pinned Transformers source requiringhuggingface-hub>=1.5.0,<2.0. ImportingAutoConfigthen failed when Transformers imported the absenthttpxmodule.The split install resolves the pinned Transformers source and its dependencies together with the editable project, installs only VibeVoice with
--no-deps, and immediately exercisesfrom transformers import AutoConfig. It neither blindly addshttpxnor changes either source revision.Primary evidence: pinned Transformers dependencies, upstream VibeVoice metadata, and the failed synthetic parity job.
Both 40-character source pins remain unchanged:
640a08a597034221ca1c4fc0c129cf011817922579e516a3e20b599f137c9da03410a2a0b473b63bAll five install steps retain actual dependency resolution and AutoConfig import smoke, and the YAML-structure Python tests were removed following review.
Validation
ruff format,ruff check,ruff format --check, andgit diff --check: passed.ci-vibevoice-deps-validation-v2.log.A local fresh-venv network resolver run was not performed; host CI validation remains pending. No installs, full-model, or GPU runs were performed.
VibeVoice's upstream metadata still declares Transformers
<5. This preserves the existing reference integration's deliberate--no-depsexception for VibeVoice; it does not resolve that pre-existing metadata mismatch or apply the exception to Transformers itself.This PR is standalone from main
d69efe03a9f4c1ada744bc31dd01077a710b3c39and independent of #754 and #787.