Conversation
The updater only handled vcpkg_from_pythonhosted and vcpkg_from_github
ports, and only ones named py-*, so arrow was never visited and would
not have matched either fetch method anyway.
Add update_distfile_ports(), which walks every port and updates the ones
that opt in by declaring their upstream GitHub repository in the
portfile:
# GITHUB_REPO apache/arrow
# GITHUB_REF apache-arrow-${VERSION}
The latest non-prerelease tag is resolved through the existing
get_latest_tag(), and the archive is downloaded from the port's own URLS
value with ${VERSION} substituted, so arrow keeps using the official
Apache source release rather than the GitHub tarball.
Requiring the marker keeps the other non-py- ports (python3, gdal,
pybind11, vcpkg-tool-*) out of the automation for now.
Also extract get_version_key() and reuse it in update_github_ports().
This bumps arrow 23.0.1 -> 25.0.1; all five patches still apply.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
Author
|
superseded by #270 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updater only handled vcpkg_from_pythonhosted and vcpkg_from_github ports, and only ones named py-*, so arrow was never visited and would not have matched either fetch method anyway.
Add update_distfile_ports(), which walks every port and updates the ones that opt in by declaring their upstream GitHub repository in the portfile:
The latest non-prerelease tag is resolved through the existing get_latest_tag(), and the archive is downloaded from the port's own URLS value with ${VERSION} substituted, so arrow keeps using the official Apache source release rather than the GitHub tarball.
Requiring the marker keeps the other non-py- ports (python3, gdal, pybind11, vcpkg-tool-*) out of the automation for now.
Also extract get_version_key() and reuse it in update_github_ports().
This bumps arrow 23.0.1 -> 25.0.1; all five patches still apply.