Conversation
3nids
added a commit
that referenced
this pull request
Aug 31, 2026
The port-version bump from #273 (python-extension-args.patch) never reached the version database: the post-merge "Auto update version db" workflow computed it but failed to push (403), so consumers resolving through the baseline kept getting git-tree 28458c5 — the unpatched tree — and the macOS -std=c++11 build failure with it. Generated with the same command the workflow runs.
3nids
added a commit
that referenced
this pull request
Aug 31, 2026
Both "Format vcpkg.json" and "Check versions" run tools that rewrite files in place and exit 0 regardless, so neither step asserted anything -- PR #273 went green while leaving the version database stale, and the only thing that would have caught it was the post-merge job, whose push is currently rejected with a 403. Compare the working tree after each step and fail with a message saying what to run locally. Scoped by pathspec so unrelated stray files cannot trip them, and using git status rather than git diff so that a brand new versions/<x>-/<port>.json is caught too.
3nids
added a commit
that referenced
this pull request
Aug 31, 2026
* Update versions.db for gdal 3.13.3#1 The port-version bump from #273 (python-extension-args.patch) never reached the version database: the post-merge "Auto update version db" workflow computed it but failed to push (403), so consumers resolving through the baseline kept getting git-tree 28458c5 — the unpatched tree — and the macOS -std=c++11 build failure with it. Generated with the same command the workflow runs. * ci: make the static checks actually fail Both "Format vcpkg.json" and "Check versions" run tools that rewrite files in place and exit 0 regardless, so neither step asserted anything -- PR #273 went green while leaving the version database stale, and the only thing that would have caught it was the post-merge job, whose push is currently rejected with a 403. Compare the working tree after each step and fail with a message saying what to run locally. Scoped by pathspec so unrelated stray files cannot trip them, and using git status rather than git diff so that a brand new versions/<x>-/<port>.json is caught too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.