[Fix #1598] Support uri-reference in type generator - #1602
Merged
Conversation
Fix open-workflow-specification#1598 Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the local workflow JSON/YAML schema and the type-generation configuration so that schema fields using the uri-reference format can be incorporated and still generate the intended Java types.
Changes:
- Switch schema
formatforLiteralUrifromuritouri-reference. - Configure
jsonschema2pojoin thetypesmodule to mapuri-referencetojava.net.URI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| types/src/main/resources/schema/workflow.yaml | Updates schema format to uri-reference to align with the spec/schema evolution. |
| types/pom.xml | Adds a formatTypeMapping entry so uri-reference generates as java.net.URI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fjtirado
changed the title
ricardozanini
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1598