fix(sessions): accept namespaced compaction model names - #5225
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a338a568bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed the complete diff at 88c0e672dbc3182dd247fb1de8f78346a6b03fb1; no actionable findings. Namespace removal now precedes fine-tuned model parsing, while the complete original identifier is retained for responses.compact. The parameterized public-boundary tests cover bare, nested, and namespaced fine-tuned models plus rejection of non-OpenAI model families.
Verified all 22 hosted checks passed on this commit. Source review only; I did not run local tests or make live gateway requests.
|
@codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
2 participants
Summary
This pull request fixes
OpenAIResponsesCompactionSessionrejecting gateway-prefixed model names such asopenai/openai/gpt-5.6-terra. Validation checks the final slash-separated model-name segment while the original identifier is forwarded unchanged toresponses.compact.The runtime fix is one line. Existing tests cover bare and fine-tuned names, single and nested namespaces, namespaced fine-tuned models, unchanged request forwarding, and rejection of non-OpenAI model families.
Test plan
mainand addressing review feedback.Issue number
Fixes #5214
Checks
.agents/skills/code-change-verification/scripts/run.sh