Skip to content

ci: open release PRs ready for review - #5227

Merged
jbeckwith-oai merged 1 commit into
mainfrom
codex/release-please-ready
Sep 28, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
codex/release-please-ready

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Collaborator

Summary

This pull request makes Release Please open release PRs ready for review by setting draft-pull-request to false. It updates the existing config assertion and maintainer guidance so API snapshot regeneration remains required before merging, alongside checks and code-owner approval. Versioning, changelog sections, workflow permissions, and manual publication are unchanged.

Test plan

  • Release metadata tests: 2 passed.
  • Pinned Release Please 17.6.0 Manifest probe: both fix and feature proposals have draft: false and consistent project, lockfile, manifest, and source versions.
  • Independent review: no findings.
  • Required formatting, lint, type checks, and full test suite passed with the documented Codex sandbox environment.

Checks

  • Updated the relevant regression assertion.
  • Ran .agents/skills/code-change-verification/scripts/run.sh.
  • Confirmed all verification steps pass and final diff matches the reviewed content.
  • Completed independent review before submission.

@jbeckwith-oai
jbeckwith-oai requested review from a team, rm-openai and seratch as code owners September 28, 2026 18:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T18:27:38.092588Z 37dbb52 Manual request
🔒 Security Review ✅ Completed 2026-09-28T18:27:02.255824Z 37dbb52 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jbeckwith-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 37dbb52fbf

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 37dbb52fbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread release-please-config.json

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 37dbb52fbf6bc8c7f996a3ec29c87686b5666576. No actionable findings.

The pinned Release Please action carries the explicit draft-pull-request: false through to PR creation. The release instructions and existing config assertion agree with that change, while snapshot preparation, required checks/code-owner review, and manual publication remain required. I also verified that the existing release PR #5226 is already open and non-draft, addressing the earlier migration concern.

Validation: source review of all three changed files, the pinned action's configuration path, and the surrounding release/snapshot workflows. All 22 hosted checks pass on this commit, including the Python/Windows test matrices, packaged/prospective contract checks, lint/type checks, docs, and CodeQL. I did not run tests or builds locally.

@jbeckwith-oai
jbeckwith-oai merged commit 8e43500 into main Sep 28, 2026
22 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the codex/release-please-ready branch September 28, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants