Repository navigation
Allow VMs on shared networks to discover each other's IPs via DNS - #225
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
edi-oai
force-pushed
the
dev/edi/vm-dns-discovery
branch
from
October 29, 2026 18:14
7c7d3a9 to
e0afe07
Compare
yzhuang-oai
reviewed
Oct 29, 2026
edi-oai
force-pushed
the
dev/edi/vm-dns-discovery
branch
from
October 29, 2026 18:50
e0afe07 to
b45afbd
Compare
yzhuang-oai
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifying a
namefor at least one VM through JSON-RPC or using--vm-nameon the CLI enables Softnet's built-in DNS server.This allows VMs to find each other's IPs using DNS names like
<name>.internal.Queries for these internal names bypass the firewall policy, since naming a VM explicitly opts it into DNS discovery. All other DNS queries remain subject to it.